Normally I'd steer well clear but I've got to make an exception because
Problem Description:
Prior to https://github.com/ParadiseSS13/Paradise/pull/7832, Vox would go into deep crit within ~5min 25sec when breathing normal station air.
Now, oxygen toxicity is trivial. Vox will most likely die of liver failure after 30 minutes rather than breathing the air directly. At ~5min 25sec a Vox will, on average, only have 40 toxin damage and will be able to continually recover from vomiting.
I suspect this also affects how plasma/CO2 toxicity is handled. tl;dr: As Vox, prior to https://github.com/ParadiseSS13/Paradise/pull/7417 I would be in deep crit after 5min 25sec breathing regular station air. Now, I can breathe station air with nearly negligible ill effects. What did you expect to happen:
Gas toxicity is an empty threat and no longer poses a danger to races who have it as one of their main balancing factors. What happened instead:
I can spend a shift maskless and drink tea once in a while as a Vox while gasping straight dust without penalty. Why is this bad/What are the consequences:
One of the core mechanics of the game has had a critical flaw for a year that dramatically affects the balancing of humanoid species. Steps to reproduce the problem:
Huff toxic gas. When did the problem start happening:
This was caused by https://github.com/ParadiseSS13/Paradise/pull/7832. It may be related to adjustments to breath math and can probably be compensated for by adjusting `safe_<gas here>_max` factors on the lung objects. Other information:
While I have solid numbers on Vox station air survivability IDK what it was like for plasma or CO2 prior to the refactor.
I posted this because it has been SO LONG without discussion/detection of this issue that it's probably good to figure how relevant this mechanic should be and what reasonable kill times should be in today's game rather than just posting a bandaid PR and get blitzed
We could probably go about this by roughly dialing in TTK/Lethality with the ratios in places like this and then fine tune it using the values in places like this
3.5 minute TTK would be ideal in my opinion as ~5.5 seemed awfully drawn out for what was meant to be a critical balancing point.
Pic below: Vox breathing station air for 5min 25sec on 2018/11/13
Some Vox related metrics: https://github.com/ParadiseSS13/Paradise/pull/7417