KasparoVv Posted November 14, 2018 Posted November 14, 2018 (edited) Normally I'd steer well clear but I've got to make an exception because Problem Description: Prior to https://github.com/ParadiseSS13/Paradise/pull/7832, Vox would go into deep crit within ~5min 25sec when breathing normal station air. Now, oxygen toxicity is trivial. Vox will most likely die of liver failure after 30 minutes rather than breathing the air directly. At ~5min 25sec a Vox will, on average, only have 40 toxin damage and will be able to continually recover from vomiting. I suspect this also affects how plasma/CO2 toxicity is handled.tl;dr: As Vox, prior to https://github.com/ParadiseSS13/Paradise/pull/7417 I would be in deep crit after 5min 25sec breathing regular station air. Now, I can breathe station air with nearly negligible ill effects.What did you expect to happen: Gas toxicity is an empty threat and no longer poses a danger to races who have it as one of their main balancing factors.What happened instead: I can spend a shift maskless and drink tea once in a while as a Vox while gasping straight dust without penalty.Why is this bad/What are the consequences: One of the core mechanics of the game has had a critical flaw for a year that dramatically affects the balancing of humanoid species.Steps to reproduce the problem: Huff toxic gas.When did the problem start happening: This was caused by https://github.com/ParadiseSS13/Paradise/pull/7832.It may be related to adjustments to breath math and can probably be compensated for by adjusting `safe_<gas here>_max` factors on the lung objects.Other information: While I have solid numbers on Vox station air survivability IDK what it was like for plasma or CO2 prior to the refactor. I posted this because it has been SO LONG without discussion/detection of this issue that it's probably good to figure how relevant this mechanic should be and what reasonable kill times should be in today's game rather than just posting a bandaid PR and get blitzed We could probably go about this by roughly dialing in TTK/Lethality with the ratios in places like this and then fine tune it using the values in places like this 3.5 minute TTK would be ideal in my opinion as ~5.5 seemed awfully drawn out for what was meant to be a critical balancing point. Pic below: Vox breathing station air for 5min 25sec on 2018/11/13 Some Vox related metrics: https://github.com/ParadiseSS13/Paradise/pull/7417 Edited November 15, 2018 by KasparoVv 2 1 2 Link to comment https://www.paradisestation.org/forum/topic/14789-correct-the-lung-refactor-of-7832s-massive-nerf-to-gas-toxicity/ Share on other sites More sharing options...
Ziiro Posted November 15, 2018 Posted November 15, 2018 When I was porting them over to Oracle originally, I actually thought it was strange how little damage they were taking. I had to make "oxy_damage_multiplier" and add that as a var to the lungs. (This var could also make it so you could make more robust lungs, too!) 2 Link to comment https://www.paradisestation.org/forum/topic/14789-correct-the-lung-refactor-of-7832s-massive-nerf-to-gas-toxicity/#findComment-120870 Share on other sites More sharing options...
KasparoVv Posted November 16, 2018 Author Posted November 16, 2018 (edited) Sounds like a good idea because of how it lets you still have that grace period before the damage kicks in and adjust how severe the damage is in isolation rather than only being able to increase the damage by also decreasing how much o2 needs to be in the air before your body reacts However I think gas toxicity overall rather than just oxygen is too low after seeing just how wimpy the oxygen allergy Vox have is now Edited November 16, 2018 by KasparoVv Link to comment https://www.paradisestation.org/forum/topic/14789-correct-the-lung-refactor-of-7832s-massive-nerf-to-gas-toxicity/#findComment-120890 Share on other sites More sharing options...
Benjaminfallout Posted November 19, 2018 Posted November 19, 2018 I've gone full rounds without a mask on by just drinking tea from the green center. Link to comment https://www.paradisestation.org/forum/topic/14789-correct-the-lung-refactor-of-7832s-massive-nerf-to-gas-toxicity/#findComment-120995 Share on other sites More sharing options...
Spartan Posted November 28, 2018 Posted November 28, 2018 This should be changed once https://github.com/ParadiseSS13/Paradise/pull/10322 is completed. Link to comment https://www.paradisestation.org/forum/topic/14789-correct-the-lung-refactor-of-7832s-massive-nerf-to-gas-toxicity/#findComment-121363 Share on other sites More sharing options...
KasparoVv Posted January 1, 2019 Author Posted January 1, 2019 (edited) Currently being addressed by this PR. Blessed Edited January 1, 2019 by KasparoVv Link to comment https://www.paradisestation.org/forum/topic/14789-correct-the-lung-refactor-of-7832s-massive-nerf-to-gas-toxicity/#findComment-122925 Share on other sites More sharing options...
Recommended Posts