Remove Latejoin Only Slots

[Rurik]

There is 0 reason you should be more likely to get the job you want by not readying up, and just late joining 2 seconds after round begins. I shouldn't be fucked out of a security roll cause the extra officer slots are only available to late joins. Late join slots should be composed of what slots are left over, not reserved slots.

This feature doesn't help with giving jobs to real late joiners either, as these slots, particularly security officer slots, are taken near instantly after shift start. The exception is lowpop.

As it stands this feature only serves to punish those readying up and further reward those who latejoin 1 second after shift start to avoid being an antags target.

[AffectedArc07]

To be clear, this can be chalked up as a bug to be honest.

 

Nerd ramble in the expandable below

Spoiler

We divide jobs here on line 229

Then on 324 (in the same function) we check if we should allocate highpop slots

The original implementation in 2018 (https://github.com/ParadiseSS13/Paradise/pull/8995) did it on roundstart for some reason, instead of before.

Sidenote - that sleep(10 SECONDS) is actually what caused all the roundstart lag but dont worry about it.

 

The highpop trigger is 80 clients.

Which is 15/24 hours of the day, damn near 2 thirds of it. 

TLDR - This loads the highpop slots after the round has started, when really it should be before jobs are divvied out. 

 

[Meow19]

Didn't knew that's a thing, ridiculous.

[TheBadPerson]

This is not poggers