Spacemanspark Posted September 14, 2015 Posted September 14, 2015 Believe it or not, IPC's can currently only change their monitor color. It'd be nice if they could change the body color as well (A feature Baycode has, I believe. Unfortunately, they don't have the options like we do to actually pick a color, and you have to spend a half hour clicking the 'randomize' button in the hopes you get the colors you want. *buzz.) Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/ Share on other sites More sharing options...
MarvinMartian34 Posted September 14, 2015 Posted September 14, 2015 yes pls Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-39376 Share on other sites More sharing options...
NTSAM Posted September 14, 2015 Posted September 14, 2015 oh feck better put this BIG thumbs up in a spoiler Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-39377 Share on other sites More sharing options...
Mrs Dobbins Posted September 14, 2015 Posted September 14, 2015 Agreed. My green monitor would look better with a lime-green body. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-39383 Share on other sites More sharing options...
Fox McCloud Posted September 15, 2015 Posted September 15, 2015 Yup. Generally agree. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-39395 Share on other sites More sharing options...
davidchan Posted September 15, 2015 Posted September 15, 2015 Plz and thank you. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-39405 Share on other sites More sharing options...
Spacemanspark Posted September 24, 2015 Author Posted September 24, 2015 *COUGH* BUMP *COUGH* Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40355 Share on other sites More sharing options...
Tauka Usanake Posted September 24, 2015 Posted September 24, 2015 You know, I can see someone, maybe reasonable but most likely not, complain about this in a way that it will turn into more furry hate. "Oh, IPCs can get their own body color but you want to limit the anthropomorphic character to certain colors? RAEG! IMA DDOS YOU ALL!" But in all seriousness though this should be a thing. I don't play IPC (no karma ;( ) but it should be an option for customization. How hard would it be to make this happen? Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40368 Share on other sites More sharing options...
Spacemanspark Posted September 24, 2015 Author Posted September 24, 2015 Could be ported from Bay, I assume. I'd assume not terribly hard. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40373 Share on other sites More sharing options...
tigercat2000 Posted September 24, 2015 Posted September 24, 2015 Uh, Bay doesn't have colorable IPC's, last I checked. I don't think this is even feasible; Skin color is handled at the external organ level; IPC's use robotic external organs; Robotic external organs do not get colored. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40375 Share on other sites More sharing options...
davidchan Posted September 24, 2015 Posted September 24, 2015 Unbound/BestRP had it, they run off of baycode last I checked, I vividly remember running around as a bright red IPC on their server when I played. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40380 Share on other sites More sharing options...
tigercat2000 Posted September 24, 2015 Posted September 24, 2015 Unbound/BestRP had it, they run off of baycode last I checked, I vividly remember running around as a bright red IPC on their server when I played. Unbound/BestRP code is massively out of date with baydev, if I recall correctly. This would have been easy-- before the whole organ overhaul. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40434 Share on other sites More sharing options...
Shadeykins Posted September 26, 2015 Posted September 26, 2015 This has been brought up before (about 9 months ago). It's a toggle that's disabled in the code, and is easily made selectable again. So-and-so coder didn't want another "rainbow species" for some reason. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40618 Share on other sites More sharing options...
MarkvA Posted September 26, 2015 Posted September 26, 2015 No, pretty sure that was the IPC head color, which was enabled. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40623 Share on other sites More sharing options...
tigercat2000 Posted September 26, 2015 Posted September 26, 2015 This has been brought up before (about 9 months ago). It's a toggle that's disabled in the code, and is easily made selectable again. So-and-so coder didn't want another "rainbow species" for some reason. It's definitely not that simple. I spent about an hour looking into this, and yes, I did try to just enable the has_body_color flag; It doesn't work. Why don't I just give a detailed explanation of why it doesn't work? So, first off- the HAS_BODY_COLOR flag does not actually control if you see the body color preference; it's snowflaked into races checks. But that's a simple solution. So, moving on. You select a body color; When your character is made, their r_skin, b_skin, and g_skin variables are set according to the color you selected. From there, it moves to the icon generating phase. Human base icons are now generated at the organ level; https://github.com/ParadiseSS13/Paradis ... an_icon.dm When humans want to make a new icon, first they check if anything has changed, or if they can use a cached icon that was already made. https://github.com/ParadiseSS13/Paradis ... #L231-L347 The specific part of this check that handles the actual base body, their arms, chest, head, so on, is here: https://github.com/ParadiseSS13/Paradis ... #L278-L297 That code calls organ.get_icon, which is here; https://github.com/ParadiseSS13/Paradis ... m#L72-L113 Colored parts are handled in organ.get_icon, specifically, right here; https://github.com/ParadiseSS13/Paradis ... on.dm#L108 If you notice, that part is behind an else; First, it has an if(skeletal), which means it returns the skeleton icon if that mob is supposed to be a skeleton. Then, second, it has an else if (status & ORGAN_ROBOT), which returns just the robot icon, without ever calling the part that blends skin tone. In order to fix this, we would have to add a color blend behind the else if (status & ORGAN_ROBOT) check; But, we can't do that. If we did, tajara and everything else with a skin color would color robotic limbs, which isn't desired. Is that a good enough explanation of why this isn't feasible? Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40625 Share on other sites More sharing options...
tigercat2000 Posted September 27, 2015 Posted September 27, 2015 Well, call me a liar or whatever, but after fucking with the organ system for hours to get something else to work, I got this to work. https://github.com/ParadiseSS13/Paradise/pull/2194 Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40692 Share on other sites More sharing options...
Shadeykins Posted September 27, 2015 Posted September 27, 2015 No, pretty sure that was the IPC head color, which was enabled. Ah! I stand corrected. Link to comment https://www.paradisestation.org/forum/topic/5395-allow-ipcs-to-change-their-body-color/#findComment-40700 Share on other sites More sharing options...
Recommended Posts