DrunkDwarf Posted January 31, 2017 Posted January 31, 2017 The Vending Machine in Mr Chang's doesn't hold a lot of food currently, and has no way of being refilled unlike a lot of other vending machines. To allow more use of Mr Chang's (potentially for players to remodel to turn into a fully-fledged takeaway) it would be great if this vending machine could be refilled by using a refill canister, either included as part of the Snack refill crate from Cargo, or as a separate crate, whichever is easiest. From a quick glance at the code, i'm assuming this would be a straightforward change, that could open up creative use of that particular part of the Dorms. Link to comment https://www.paradisestation.org/forum/topic/9270-mr-changs-vending-machine-refill-canister/ Share on other sites More sharing options...
Shadeykins Posted February 3, 2017 Posted February 3, 2017 The Vending Machine in Mr Chang's doesn't hold a lot of food currently, and has no way of being refilled unlike a lot of other vending machines. To allow more use of Mr Chang's (potentially for players to remodel to turn into a fully-fledged takeaway) it would be great if this vending machine could be refilled by using a refill canister, either included as part of the Snack refill crate from Cargo, or as a separate crate, whichever is easiest. From a quick glance at the code, i'm assuming this would be a straightforward change, that could open up creative use of that particular part of the Dorms. I believe the issue is it doesn't use refill carts at all. From a coding perspective, making it accept the snack vending machine ones shouldn't be too hard and would solve this problem. Link to comment https://www.paradisestation.org/forum/topic/9270-mr-changs-vending-machine-refill-canister/#findComment-78397 Share on other sites More sharing options...
DrunkDwarf Posted February 4, 2017 Author Posted February 4, 2017 I had a further look at the code, and decided to try my hand at implementing this, figured it was a good way to start contributing and learn how things are structured. Made the change, set up a local server instance of Paradise, tested my change, and then submitted a Pull Request to Github. https://github.com/ParadiseSS13/Paradise/pull/6315 Was recently merged yay. I've a few ideas of other things to implement, minor things that wouldn't affect gameplay any. I'll study the code more and possibly make further suggestions to see how people feel about them. Link to comment https://www.paradisestation.org/forum/topic/9270-mr-changs-vending-machine-refill-canister/#findComment-78583 Share on other sites More sharing options...
dadols Posted February 4, 2017 Posted February 4, 2017 I had a further look at the code, and decided to try my hand at implementing this, figured it was a good way to start contributing and learn how things are structured. Made the change, set up a local server instance of Paradise, tested my change, and then submitted a Pull Request to Github. https://github.com/ParadiseSS13/Paradise/pull/6315 Was recently merged yay. I've a few ideas of other things to implement, minor things that wouldn't affect gameplay any. I'll study the code more and possibly make further suggestions to see how people feel about them. Congrats Link to comment https://www.paradisestation.org/forum/topic/9270-mr-changs-vending-machine-refill-canister/#findComment-78593 Share on other sites More sharing options...
Recommended Posts